Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached and cachedBy will not overwrite global state changes #1268

Merged
merged 1 commit into from Aug 29, 2016

Conversation

Projects
None yet
2 participants
@CthulhuDen
Copy link
Contributor

CthulhuDen commented Aug 28, 2016

Fixes issue #1266 (only it also prevents overwriting any part of the changed state, not only cache. If actions to be cached were not supposed to change global state it should have been documented).

@CthulhuDen CthulhuDen closed this Aug 28, 2016

@CthulhuDen CthulhuDen reopened this Aug 28, 2016

@snoyberg snoyberg merged commit 0881364 into yesodweb:master Aug 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Aug 29, 2016

Thanks!

snoyberg added a commit that referenced this pull request Aug 29, 2016

@CthulhuDen CthulhuDen deleted the CthulhuDen:issue-1266 branch Aug 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.