Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] byLabelContain #1480

Closed
pythonissam opened this issue Jan 28, 2018 · 2 comments
Closed

[Suggestion] byLabelContain #1480

pythonissam opened this issue Jan 28, 2018 · 2 comments

Comments

@pythonissam
Copy link
Contributor

In #1454, we put byLabel into deprecated. However, it might be useful when we have labels that are too long to write. Since byLabel matches over the prefix of labels, we can shorten their names and pass them to byLabel. So I think it's nice if we can rename it as byLabelContain and fix existing bugs. Thank you for your consideration.
@snoyberg
Copy link
Member

No objection with this, interested in sending a PR?

@pythonissam
Copy link
Contributor Author

Yes! I'd love to:)

@pythonissam pythonissam mentioned this issue Feb 3, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyberg @pythonissam