Calling maybeAuth and friends in version 1.6

[paul-rouse]

Am I being totally thick (entirely possible 😄)? What is the intended way to upgrade this sort of code to version 1.6, now that maybeAuth is in AuthHandler?

getHomeR :: Handler Html
getHomeR = do
    mauth <- maybeAuth
    ...

I can write a function that runs it, but it messes with the RunHandlerEnv, which hardly seems right! Have I missed something?

[snoyberg]

Great catch, this is definitely a bug in the API. I'll push out a fix shortly I hope.

[paul-rouse]

I did wonder whether the function I wrote could be made general, but I think it would have to be generated somewhere in the template haskell, since, at least the way I've done it, it bakes in the master route constructor, and therefore the foundation type. Probably not ideal, though.

runAuthHandler :: SubHandlerFor Auth App a -> HandlerFor App a
runAuthHandler (SubHandlerFor f) = HandlerFor $ \hd -> f hd
      { handlerEnv =
          let rhe = handlerEnv hd
          in rhe { rheRoute = case rheRoute rhe of
                                Just (AuthR subR) -> Just subR
                                _                 -> Nothing
                 , rheRouteToMaster = AuthR
                 , rheChild = getAuth (rheSite rhe)
                 }
      }

getHomeR :: Handler Html
getHomeR = do
    mauth <- runAuthHandler maybeAuth

[snoyberg]

I've pushed a commit which I believe addresses this, a3f1302. Can you give it a shot?

[paul-rouse]

Great, yes, that works perfectly in the example I was trying (the test for yesod-auth-hashdb).

Thanks!

[snoyberg]

Awesome, thanks for confirming. I've just released version 1.6.1.