Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the advice in the
makeLogger
haddock practical:For logging during app startup, it recommends creating a
Logger
, using during startup, and then supplying it tomakeLogger
when creating theYesod
instance. But for that to be practical, you need access to the default implementations of the various logging-related methods ofYesod
and/or theformatLogMessage
function. Unfortunately, none of those are available before theYesod
instance is actually created, leading to a chicken-and-egg problem.This PR moves the default implementations of the logging-related methods to separate functions that don't depend on the
Yesod
instance, and exports all of those plusformatLogMessage
fromYesod.Core
.