-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show source location for logs that don't have that information #1027
Conversation
Also, I would use a |
|
Looks like I'll leave @gregwebs I like your suggestion about using a |
So, I'm trying to test this, and it builds correctly with stack, but I want to make sure that it has the expected runtime behavior. I created a minimal yesod+sqlite single-file app named
Everything I try gives:
Does anyone have any suggestions for using a library you build with stack? |
You probably are using a different snapshot. Try running stack build yesod first and see if that changes the result. |
And FYI, there's also stack runghc. |
Thanks Michael. I had forgotten that Something weird is happening. The changes that I've introduced strip off the piece at the end for anything that uses |
Wait a moment. I think I know why. |
Nevermind, everything is good, and this should be ready to be merged in. I was building one of the example apps from the yesod book. It uses runStderrLoggingT for the SQL logs, which cuts yesod out of the equation and uses monad-logger's |
This is ready to be merged in. It has the expected behavior. |
Cool stuff! These |
Don't show source location for logs that don't have that information
#1026
Don't merge this yet. I haven't tested it. Two questions:
<>
instead ofmappend
? I'd much rather switch to that.