Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsString instance for WidgetT site m () #1038

Merged
merged 4 commits into from
Jul 23, 2015
Merged

Add IsString instance for WidgetT site m () #1038

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0063545
Add IsString instance for WidgetT site m ()
andrewthad Jul 21, 2015
4e354c9
Improve type inference for WidgetT IsString instance
andrewthad Jul 21, 2015
66ed314
Document IsString instance for WidgetT.
creichert Jul 21, 2015
a5a627d
Clarify IsString instance for Widget only works with Strings.
creichert Jul 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion yesod-core/Yesod/Core/Types.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import qualified Network.Wai.Parse as NWP
import System.Log.FastLogger (LogStr, LoggerSet, toLogStr, pushLogStr)
import qualified System.Random.MWC as MWC
import Network.Wai.Logger (DateCacheGetter)
import Text.Blaze.Html (Html)
import Text.Blaze.Html (Html, toHtml)
import Text.Hamlet (HtmlUrl)
import Text.Julius (JavascriptUrl)
import Web.Cookie (SetCookie)
Expand Down Expand Up @@ -250,6 +250,10 @@ instance (a ~ (), Monad m) => Monoid (WidgetT site m a) where
mempty = return ()
mappend x y = x >> y
instance (a ~ (), Monad m) => Semigroup (WidgetT site m a)
instance Monad m => IsString (WidgetT site m ()) where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll get better type inference with:

instance (Monad m, a ~ ()) => IsString (WidgetT site m a)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! That dumb trick I always forget.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only remembered because the previous instance uses it

On Tue, Jul 21, 2015, 8:36 AM Andrew Martin notifications@github.com
wrote:

In yesod-core/Yesod/Core/Types.hs
#1038 (comment):

@@ -250,6 +250,10 @@ instance (a ~ (), Monad m) => Monoid (WidgetT site m a) where
mempty = return ()
mappend x y = x >> y
instance (a ~ (), Monad m) => Semigroup (WidgetT site m a)
+instance Monad m => IsString (WidgetT site m ()) where

Ah! That dumb trick I always forget.

—
Reply to this email directly or view it on GitHub
https://github.com/yesodweb/yesod/pull/1038/files#r35116687.

fromString = toWidget . toHtml . T.pack
where toWidget x = WidgetT $ const $ return $ ((), GWData (Body (const x))
mempty mempty mempty mempty mempty mempty)

type RY master = Route master -> [(Text, Text)] -> Text

Expand Down