Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for aeson's toEncoding function (>= 0.11) #1241

Merged
merged 1 commit into from Jun 20, 2016

Conversation

Projects
None yet
2 participants
@lippling
Copy link

lippling commented Jun 20, 2016

@snoyberg so here is the first draft.

@lippling lippling referenced this pull request Jun 20, 2016

Closed

aeson-0.11 - toEncoding #1240

@lippling

This comment has been minimized.

Copy link
Author

lippling commented Jun 20, 2016

Build failed with: The job exceeded the maxmimum time limit for jobs, and has been terminated.

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 20, 2016

I've restarted that build. Initial review of the code looked good, I'll go through more closely after the build succeeds.

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 20, 2016

The build failure was just due to a slow cache upload, so this is GTG.

@snoyberg snoyberg merged commit 18cd783 into yesodweb:master Jun 20, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

snoyberg added a commit that referenced this pull request Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.