urlParamRenderOverride method for Yesod class #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this method replaces urlRenderOverride because the latter lacks support for query string
|
Great approach! |
snoyberg
added a commit
that referenced
this pull request
Aug 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method replaces urlRenderOverride because the latter lacks support for query string.
While it is possible to keep API and just fix the yesodRender to add params to the result of urlRenderOverride, this solution would be incomplete in user control over query string and possibly ineffective in terms of performance. So I decided to add a new method, make that fix a default definition for it to keep thing backward compatible, and deprecate urlRenderOverride.
The fix is inside yesod-core but the patch also touches haddocks in yesod-static, replacing the name of method.