Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlParamRenderOverride method for Yesod class #1257

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
2 participants
@ran-lasgalen
Copy link

ran-lasgalen commented Aug 9, 2016

This method replaces urlRenderOverride because the latter lacks support for query string.

While it is possible to keep API and just fix the yesodRender to add params to the result of urlRenderOverride, this solution would be incomplete in user control over query string and possibly ineffective in terms of performance. So I decided to add a new method, make that fix a default definition for it to keep thing backward compatible, and deprecate urlRenderOverride.

The fix is inside yesod-core but the patch also touches haddocks in yesod-static, replacing the name of method.

Artem Chuprina
urlParamRenderOverride method for Yesod class
this method replaces urlRenderOverride because the latter lacks support for query string
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Aug 10, 2016

Great approach!

@snoyberg snoyberg merged commit 159da2e into yesodweb:master Aug 10, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

snoyberg added a commit that referenced this pull request Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.