What I did to avoid the duplicate cookie problem

[bitemyapp]

Putting this up because this is what we're still using at the moment, not sure you remember that conversation or not.

From this: #1247

[snoyberg]

CC @MaxGabriel

[bitemyapp]

@snoyberg By the by, part of the reason I want this out of our packages: listing in our stack.yaml is that it seems like Stack ends up rebuilding everything in our packages list unconditionally, even stuff with extra-dep and that I know is cached. Any idea what might be going on there?

[MaxGabriel]

I think this PR matches the behavior recommended in RFC 6265:

Servers SHOULD NOT include more than one Set-Cookie header field in
the same response with the same cookie-name. (See Section 5.2 for
how user agents handle this case.)

And it solves the issue, so I think this should be merged, and #1248 should be merged as well

[bitemyapp]

@snoyberg 👍 to what @MaxGabriel said :)

[snoyberg]

Go for it if I don't get too it first. I'm on quasi vacation right now, so
I might be slower than usual.

On Sat, Aug 13, 2016, 6:06 AM Chris Allen notifications@github.com wrote:

@snoyberg https://github.com/snoyberg 👍 to what @MaxGabriel
https://github.com/MaxGabriel said :)

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1258 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADBB9GVa2auw-o9SpIlOepRHhHaXx16ks5qfTSrgaJpZM4Jgpqk
.

[bitemyapp]

@snoyberg I don't have commit bit, do you @MaxGabriel?

[MaxGabriel]

Ok, both PRs are merged now, had to fix a changelog conflict in mine.

[lloucas-imvu]

I think this PR matches the behavior recommended in RFC 6265:

Servers SHOULD NOT include more than one Set-Cookie header field in
the same response with the same cookie-name. (See Section 5.2 for
how user agents handle this case.)
And it solves the issue, so I think this should be merged, and #1248 should be merged as well

yesod/yesod-core/Yesod/Core/Internal/Response.hs

Line 90 in 8bbe91c

headerToPair (DeleteCookie key path) =

It seems to me that this explicitly does include 2 Set-Cookie header fields with the same name.
In fact I am seeing this behaviour after updating to yesod-core 1.4.24

< Set-Cookie: sandboxCookie=; path=/; expires=Thu, 01-Jan-1970 00:00:00 GMT
< Set-Cookie: sandboxCookie=12345; Path=/; Expires=Wed, 01-Jan-2020 00:00:00 GMT; Domain=.d.c
< Set-Cookie: sandboxCookie-id=; path=/; expires=Thu, 01-Jan-1970 00:00:00 GMT
< Set-Cookie: sandboxCookie-id=12345; Path=/; Expires=Wed, 01-Jan-2020 00:00:00 GMT; Domain=.d.c