-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What I did to avoid the duplicate cookie problem #1258
Conversation
CC @MaxGabriel |
@snoyberg By the by, part of the reason I want this out of our |
I think this PR matches the behavior recommended in RFC 6265:
And it solves the issue, so I think this should be merged, and #1248 should be merged as well |
@snoyberg 👍 to what @MaxGabriel said :) |
Go for it if I don't get too it first. I'm on quasi vacation right now, so On Sat, Aug 13, 2016, 6:06 AM Chris Allen notifications@github.com wrote:
|
@snoyberg I don't have commit bit, do you @MaxGabriel? |
Ok, both PRs are merged now, had to fix a changelog conflict in mine. |
It seems to me that this explicitly does include 2 Set-Cookie header fields with the same name.
|
Putting this up because this is what we're still using at the moment, not sure you remember that conversation or not.
From this: #1247