Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance of MonadHandler and MonadWidget for ExceptT #1278

Merged
merged 4 commits into from
Sep 25, 2016
Merged

Add instance of MonadHandler and MonadWidget for ExceptT #1278

merged 4 commits into from
Sep 25, 2016

Conversation

Dridus
Copy link
Contributor

@Dridus Dridus commented Sep 21, 2016

I noticed there aren't any lifting instances for ExceptT like there are for ErrorT. Hopefully it's uncontroversial to add them, but let me know if I should approach this with a different process.

@snoyberg
Copy link
Member

There's a build failure with GHC 7.8.4. Can you either use CPP to avoid those instances on older transformers, or use transformers-compat?

…version >= 7.10, since that's the first version tied to transformers-0.4.0.0 which introduced ExceptT
@Dridus
Copy link
Contributor Author

Dridus commented Sep 22, 2016

Ah whoops, sorry about that. I pushed a new commit which makes them conditional on __GLASGOW_HASKELL__ >= 710, hopefully that's acceptable.

@snoyberg
Copy link
Member

The condition should really be on the transformers package itself, not GHC.
It is possible to force different versions.

On Thu, Sep 22, 2016, 8:01 PM Ross MacLeod notifications@github.com wrote:

Ah whoops, sorry about that. I pushed a new commit which makes them
conditional on GLASGOW_HASKELL >= 710, hopefully that's acceptable.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#1278 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADBB0dIM1b8qW79I0HEJyMP4yBSQVw8ks5qsrRbgaJpZM4KDJDb
.

@Dridus
Copy link
Contributor Author

Dridus commented Sep 22, 2016

okay, I'll change it to MIN_VERSION_transformers(0,4,0). I didn't previously realize that was possible.

@Dridus
Copy link
Contributor Author

Dridus commented Sep 22, 2016

okay, I think this latest commit addresses that. let me know if it's suitable

@snoyberg snoyberg merged commit 06a6fbd into yesodweb:master Sep 25, 2016
@snoyberg
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants