Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jsAttributes for the script tag generated by julius files #1308

Merged
merged 2 commits into from Nov 27, 2016

Conversation

Projects
None yet
2 participants
@sbditto85
Copy link
Contributor

sbditto85 commented Nov 26, 2016

My first attempt at fixing issue #1300.

I tried a number of things and this is the one I settled on. Please let me know if there is a better way of doing it as I'm still learning Haskell and Yesod.

@@ -570,7 +575,7 @@ widgetToPageContent w = do
^{mkScriptTag s}
$maybe j <- jscript
$maybe s <- jsLoc
<script src="#{s}">
^{mkDefaultScriptTag s (jsAttributes master)}

This comment has been minimized.

Copy link
@snoyberg

snoyberg Nov 26, 2016

Member

You can use the *{..} syntax for multiple attributes, described at: http://www.yesodweb.com/book/shakespearean-templates#shakespearean-templates_attributes

@sbditto85

This comment has been minimized.

Copy link
Contributor Author

sbditto85 commented Nov 26, 2016

Awesome i figured i was missing something. Learn something new every day :)

@snoyberg snoyberg merged commit ed87ded into yesodweb:master Nov 27, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Nov 27, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.