added jsAttributes for the script tag generated by julius files #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Nov 26, 2016
| @@ -570,7 +575,7 @@ widgetToPageContent w = do | |||
| ^{mkScriptTag s} | |||
| $maybe j <- jscript | |||
| $maybe s <- jsLoc | |||
| <script src="#{s}"> | |||
| ^{mkDefaultScriptTag s (jsAttributes master)} | |||
There was a problem hiding this comment.
You can use the *{..} syntax for multiple attributes, described at: http://www.yesodweb.com/book/shakespearean-templates#shakespearean-templates_attributes
|
Awesome i figured i was missing something. Learn something new every day :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt at fixing issue #1300.
I tried a number of things and this is the one I settled on. Please let me know if there is a better way of doing it as I'm still learning Haskell and Yesod.