Adds curly brackets to route parser. #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
reviewed
Mar 23, 2017
|
|
||
| where | ||
| parse :: String -> ( String, String) | ||
| parse ('{':s) = fmap ('{':) $ parseBracket s |
There was a problem hiding this comment.
Is there an advantage to retaining the surrounding braces? What about simply dropping them, and then removing the need for the dynamicPieceFromString below?
There was a problem hiding this comment.
I think that would be too permissive. Otherwise, lines could contain arbitrary braces in routes. For example, the following would probably parse:
/m{}y/{route with}/{spaces} RouteR GET
I prefer the current stricter grammar that requires the braces follow '#' so that braces can only surround types in the route.
There was a problem hiding this comment.
Fair enough, that makes sense.
|
Thanks! |
snoyberg
added a commit
that referenced
this pull request
Mar 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the google group. I still need to implement the
&{}syntax.