Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaiSubsiteWithAuth #1394

Merged
merged 2 commits into from May 12, 2017

Conversation

Projects
None yet
2 participants
@mchaver
Copy link
Contributor

mchaver commented May 11, 2017

This newtype and instances will allow the WaiSubsite to pick up isAuthorized from the parent site. I followed the code for Static subsites. I am guessing it makes sense to have both WaiSubsite and WaiSubsiteWithAuth because it is possible that we want to have a WaiSubsite that ignores the parents middleware. Maybe there is a better name then WaiSubsiteWithAuth? From what I understand this will also pick up whatever middleware the parent site has.

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented May 11, 2017

This looks good. Could you additionally:

  • Bump the minor version number
  • Make an entry in the ChangeLog
  • Add a Haddock comment to WaiSubsite explaining the difference from WaiSubsiteWithAuth
  • Add a Haddock comment to WaiSubsiteWithAuth referring to WaiSubsite's docs, and a @since annotation for the new version
@mchaver

This comment has been minimized.

Copy link
Contributor Author

mchaver commented May 12, 2017

Looks like it failed to build in Travis for GHC 8.0.1. Yesod-core built fine but yesod-persistent did not.

@snoyberg snoyberg merged commit 602d1ff into yesodweb:master May 12, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented May 12, 2017

Thanks! We can ignore the build failure, it's spurious and unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.