Update mkYesodWith
and refactor so that mkYesod
uses the context parser
#1478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it looks like you're planning on introducing breaking changes, it seems like a good time for this. This PR is breaking since it updates the type of
mkYesodWith
to separate the list of contexts from the list of type arguments. This makesmkYesodWith
more general since you can now have multiple arguments for contexts. For example:This should generate something like:
I also updated
mkYesod
to use the context parser and deprecatedmkYesodWith
since you should be able to get the same functionality frommkYesod
now. Let me know if you don't want to deprecate this.mkYesodWith
was originally introduced in #1055. @Daniel-Diaz, does this look good to you?This should finish #1365.
After submitting your PR: