added: addContentDispositionFileName #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Apr 17, 2018
yesod-core/Yesod/Core/Handler.hs
Outdated
| @@ -780,6 +781,14 @@ deleteCookie a = addHeaderInternal . DeleteCookie (encodeUtf8 a) . encodeUtf8 | |||
| setLanguage :: MonadHandler m => Text -> m () | |||
| setLanguage = setSession langKey | |||
|
|
|||
| -- | Set attachment file name. | |||
| -- | |||
| -- allow UTF-8 character. | |||
There was a problem hiding this comment.
This should probably say something like: "Allows Unicode characters by encoding to UTF-8"
| @@ -780,6 +781,14 @@ deleteCookie a = addHeaderInternal . DeleteCookie (encodeUtf8 a) . encodeUtf8 | |||
| setLanguage :: MonadHandler m => Text -> m () | |||
| setLanguage = setSession langKey | |||
|
|
|||
| -- | Set attachment file name. | |||
There was a problem hiding this comment.
Can you add a ChangeLog entry, cabal version bump, and a @since comment?
There was a problem hiding this comment.
I thinked that wait other pull request.
However, If I should write before it, I write.
So I write.
yesod-core/Yesod/Core/Handler.hs
Outdated
| addContentDispositionFileName :: MonadHandler m => T.Text -> m () | ||
| addContentDispositionFileName name | ||
| = addHeader "Content-Disposition" $ | ||
| "attachment; filename*=UTF-8''" `mappend` decodeUtf8 (H.urlEncode True (encodeUtf8 name)) |
There was a problem hiding this comment.
I haven't seen this syntax before. Can you reference the relevant spec that details how this is supposed to work in a comment?
I wrote battle of multibyte from code review.
ncaq
force-pushed
the
add-addContentDispositionFileName
branch
from
d03ff94
to
a59ee6b
Compare
|
@snoyberg I wrote comment, changelog. |
snoyberg
approved these changes
Apr 18, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR:
I pushed other pull request, I checkbox after complete other pull request.
This function is setting attchment file name.
Setting is hard that allow UTF-8 multibyte character.
This function running our product.
I want to push upstream.