Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendResponseNoContent. #1565

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@StevenXL
Copy link
Member

StevenXL commented Nov 30, 2018

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@StevenXL StevenXL force-pushed the StevenXL:add-send-response-no-content branch from a915ad0 to 2a9bef3 Nov 30, 2018

@StevenXL

This comment has been minimized.

Copy link
Member Author

StevenXL commented Nov 30, 2018

I find myself continuously defining this function in new projects - many APIs will use webhooks to communicate events back to an application, and often-times they ignore the server's response. Returning the HTTP status code 204 is appropriate in these cases.

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Dec 3, 2018

LGTM, thanks!

@snoyberg snoyberg merged commit 7a2c536 into yesodweb:master Dec 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.