Use at most one valid session cookie per request #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Feb 10, 2019
yesod-core/yesod-core.cabal
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: yesod-core | |||
| version: 1.6.11 | |||
| version: 1.6.11.1 | |||
There was a problem hiding this comment.
This should be a minor version bump, to 1.6.12, since it does affect behavior.
There was a problem hiding this comment.
Fixed 馃憤 and rebased to fix the commit message.
Makes `loadClientSession` ignore all sessions in a request if more than a single session cookie decodes successfully. The prior behavior was to merge all valid session cookies' values. Bumps version to 1.6.12
snoyberg
approved these changes
Feb 11, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
loadClientSessionignore all sessions in a request if more than a single session cookie decodes successfully. The prior behavior was to merge all valid session cookies' values.Bumps version to 1.6.11.1.
Not sure if this counts as a bugfix or breaking change that would require 1.7.
Closes #994, I figured after 3 years it's probably fair game 馃檪. Feel free to close if you don't think this change is warranted anymore.
Before submitting your PR, check that you've:
After submitting your PR: