maximumContentLengthIO #1589
Merged
maximumContentLengthIO #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekingfrog
force-pushed
the
maximumContentLengthIO
branch
from
cf1edaf
to
48bfe0d
Compare
snoyberg
requested changes
Mar 17, 2019
| -- you to dynamically change the maximum file size based on some external | ||
| -- source like a database or an @IORef@. | ||
| -- | ||
| -- The default implementation uses 'maximumContentLength'. Future version of yesod will |
There was a problem hiding this comment.
How about adding a comment to maximumContentLength as well that overriding this method will cause maximumContentLength to be ignored?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised with #1588 here's an attempt to add this feature. I mostly replicated what was done for
shouldLogIO.@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: