Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximumContentLengthIO #1589

Merged
merged 3 commits into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@geekingfrog
Copy link
Contributor

geekingfrog commented Mar 15, 2019

As raised with #1588 here's an attempt to add this feature. I mostly replicated what was done for shouldLogIO.

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@geekingfrog geekingfrog force-pushed the geekingfrog:maximumContentLengthIO branch from cf1edaf to 48bfe0d Mar 15, 2019

@snoyberg
Copy link
Member

snoyberg left a comment

Looks great! Just one minor doc request.

-- you to dynamically change the maximum file size based on some external
-- source like a database or an @IORef@.
--
-- The default implementation uses 'maximumContentLength'. Future version of yesod will

This comment has been minimized.

Copy link
@snoyberg

snoyberg Mar 17, 2019

Member

How about adding a comment to maximumContentLength as well that overriding this method will cause maximumContentLength to be ignored?

@snoyberg
Copy link
Member

snoyberg left a comment

Thanks!

@snoyberg snoyberg merged commit 6a7370a into yesodweb:master Mar 17, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.