Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce JSONResponse. #1592

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Conversation

StevenXL
Copy link
Member

@StevenXL StevenXL commented Apr 12, 2019

This data type allows us to return a domain type in our handlers, even
if we eventually want to send JSON to the client.

See: https://tech.freckle.com/2015/12/21/servant-style-handlers-for-yesod/

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This data type allows us to return a domain type in our handlers, even
if we eventually want to send JSON to the client.

See: https://tech.freckle.com/2015/12/21/servant-style-handlers-for-yesod/
@StevenXL
Copy link
Member Author

Tagging #1481 and #1494

@snoyberg
Copy link
Member

Do you want to merge and release, or would you prefer I do?

@StevenXL
Copy link
Member Author

Do you want to merge and release, or would you prefer I do?

If you could do so that would be great; I'll close the old PR and Issue.

@snoyberg
Copy link
Member

Cool, doing so now, thanks!

@snoyberg snoyberg merged commit 42fbab9 into yesodweb:master Apr 13, 2019
@StevenXL StevenXL deleted the add-jsonresponse-type branch April 13, 2019 19:01
This was referenced Apr 13, 2019
@StevenXL
Copy link
Member Author

Cool, doing so now, thanks!

Always a pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants