Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend .yesodroutes file extension #1686

Merged
merged 2 commits into from
Jul 26, 2020
Merged

Recommend .yesodroutes file extension #1686

merged 2 commits into from
Jul 26, 2020

Conversation

MaxGabriel
Copy link
Member

@MaxGabriel MaxGabriel commented Jul 26, 2020 •
edited
Loading

Closes #1685

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@MaxGabriel
Copy link
Member Author

One note to the reviewer: I don't really separate out my commits into nice logical pieces, instead I usually just squash and merge them into a single commit. You may want to squash and merge to avoid commit messages like .. from being in the history

MaxGabriel added a commit to yesodweb/yesod-scaffold that referenced this pull request Jul 26, 2020
@MaxGabriel
Routes file uses .yesodroutes extension
e0e0487 
See yesodweb/yesod#1686
@MaxGabriel MaxGabriel mentioned this pull request Jul 26, 2020
Merged
@snoyberg
Copy link
Member

Awesome, thanks!

@snoyberg snoyberg merged commit 77e6c3e into master Jul 26, 2020
@snoyberg snoyberg deleted the yesodRoutesExtension branch July 26, 2020 14:12
MaxGabriel added a commit that referenced this pull request Jul 30, 2020
@MaxGabriel
Fix add-handler for new routes file path
7cfda1d 
#1686 recommended `.yesodroutes` as the file extension for the routes file, and yesodweb/yesod-scaffold#203 added that to the scaffolding. But yesod-bin assumes the file is just named `routes`.

This PR will check if the old path exists and use that, and if not use the new path.

I tested this on the yesod-scaffold repo with both the old and new filename
@MaxGabriel MaxGabriel mentioned this pull request Jul 30, 2020
Merged
5 tasks
@josephsumabat josephsumabat mentioned this pull request Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File extension for routes file
2 participants
@MaxGabriel @snoyberg