Absolute templates path #1691
Merged
Absolute templates path #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will mean that files can be build from another directory whilst still finding the package's templates
dten
force-pushed
the
absolute-templates-path
branch
2 times, most recently
from
0953cb0
to
90b3268
Compare
snoyberg
requested changes
Aug 9, 2020
yesod/Yesod/Default/Util.hs
Outdated
| @@ -64,6 +66,11 @@ addStaticContentExternal minify hash staticDir toRoute ext' _ content = do | |||
| globFile :: String -> String -> FilePath | |||
| globFile kind x = "templates/" ++ x ++ "." ++ kind | |||
|
|
|||
| -- | `globFile` but returned path is absolute and within the package the Q Exp is evaluated | |||
| -- @since 1.6.0.3 | |||
There was a problem hiding this comment.
Since this introduces a new identifier, the version number should be 1.6.1.0
dten
force-pushed
the
absolute-templates-path
branch
from
90b3268
to
8585893
Compare
|
sorted it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR:
fixes #1690
i'm 99% certain this can't break any usages of
widgetFileReloadorwidgetFileNoReloadbecause those thoseQ Expmust have already been evaluated in the correct project. unless someone was jumping through a lot of hoops to run ghc manually