Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate appropriate Handler and Widget synonyms for polymorphic sites #1697

Merged
merged 4 commits into from Sep 22, 2020
Merged

Conversation

maurges
Copy link
Contributor

@maurges maurges commented Sep 22, 2020

A fix for #1629

I've looked into #1630 which is an attempt to fix the same issue, and mine does a similar thing, but doesn't break declarations without typevars. Also mine has tests.

The tests show that the code like in the docs wouldn't compile before my change, but compile as expected with it.
I wasn't sure how to create tests for template haskell, so the tests fail at compile time.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changeset, thanks!

@snoyberg snoyberg merged commit 1b79db3 into yesodweb:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants