Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HandlerT with HandlerFor in the documentation #1703

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Replace HandlerT with HandlerFor in the documentation #1703

merged 2 commits into from
Nov 8, 2020

Conversation

jeffhappily
Copy link
Contributor

@jeffhappily jeffhappily commented Nov 8, 2020 •
edited
Loading

Fixes #1696

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@jeffhappily
Copy link
Contributor Author

Quick question, should I also update the Changelog and bump the version?

@snoyberg
Copy link
Member

snoyberg commented Nov 8, 2020

Great changes, thanks!

Quick question, should I also update the Changelog and bump the version?

That would be awesome.

@jeffhappily
Copy link
Contributor Author

For both yesod-core and yesod-eventsource ?

@snoyberg
Copy link
Member

snoyberg commented Nov 8, 2020

Yes please

snoyberg
snoyberg approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 0325a24 into yesodweb:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace HandlerT with HandlerFor in the documentation
2 participants
@jeffhappily @snoyberg