Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secure entropy source to generate CSRF tokens #1726

Merged
merged 3 commits into from
May 11, 2021

Conversation

SmartHypercube
Copy link
Contributor

@SmartHypercube SmartHypercube commented May 11, 2021

Related issue: #1725


Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks OK to me, but I'm concerned about the major version bump.

@@ -1,5 +1,5 @@
name: yesod-core
version: 1.6.19.0
version: 1.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a major version bump?

@SmartHypercube
Copy link
Contributor Author

I'm not familiar with this version style. According to https://github.com/yesodweb/yesod/blob/master/CONTRIBUTING.md#versioning , I changed behavior of existing public API (yreGen is public), so I bumped B part. What version number do you think it should be? I'll change it.

@snoyberg
Copy link
Member

I wouldn't consider this a semantic breaking change, but rather a bug fix. Either C or D would be appropriate here. I'd stick to a C bump, and would go for version 1.6.20. Thanks!

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snoyberg snoyberg merged commit 8a799d2 into yesodweb:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants