Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yesod-form: Add Monad AForm instance for transformers >=0.6 #1795

Merged
merged 2 commits into from Feb 9, 2023

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Feb 7, 2023

This is required in order to have a MonadTrans instance.

Fixes #1794

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

TeofilC added a commit to TeofilC/yesod that referenced this pull request Feb 7, 2023
@TeofilC
Copy link
Contributor Author

TeofilC commented Feb 7, 2023

I think this won't be tested on CI atm. I'm not sure what the best way forward is on that. Maybe adding a snapshot to the repo that adds new mtl and transformers to nightly

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snoyberg snoyberg merged commit 0fa3dbc into yesodweb:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yesod-form fails to build with transformers >= 0.6
2 participants