Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern relations validation #39

Merged
merged 3 commits into from May 20, 2022
Merged

Fix pattern relations validation #39

merged 3 commits into from May 20, 2022

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented May 20, 2022 •
edited

Several bugs were uncovered with regards to pattern edge validation:

  • During graph construction with extra Profiles, a Pattern or StatementTemplate in the starting Profile that was not used by another Pattern in that starting Profile would not have its attributes added to the graph.
  • Breadth-first search terminated too early (i.e. whenever a visited node appeared in the queue).
  • If all extra Profiles only had Templates (no Patterns), they would not be incorporated into the Pattern graph.

@kelvinqian00 kelvinqian00 requested review from milt and FeLungs May 20, 2022 17:28
@kelvinqian00 kelvinqian00 changed the base branch from main to version_5 May 20, 2022 17:28
milt
milt approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle, makes sense.

@kelvinqian00 kelvinqian00 merged commit ec31007 into version_5 May 20, 2022
@kelvinqian00 kelvinqian00 deleted the fix_pattern_validation branch May 20, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt milt approved these changes

@FeLungs FeLungs FeLungs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kelvinqian00 @milt @FeLungs