Gracefully fail IDNA for hostnames with underscores (fixes #53)

yeti-platform · Apr 17, 2017 · 0ece661 · 0ece661
1 parent 3ff8a75
commit 0ece661
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/core/observables/hostname.py b/core/observables/hostname.py
@@ -32,9 +32,11 @@ def normalize(self, hostname):
         hostname = Hostname.check_type(hostname)
         if not hostname:
             raise ObservableValidationError("Invalid Hostname (check_type={}): {}".format(Hostname.check_type(hostname), hostname))
-
-        self.idna = unicode(idna.encode(hostname.lower()))
-        self.value = unicode(idna.decode(hostname.lower()))
+        self.value = unicode(hostname.lower())
+        try:
+            self.idna = unicode(idna.encode(hostname.lower()))
+        except idna.core.InvalidCodepoint:
+            pass
 
     @staticmethod
     def check_type(txt):