Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cisco Umbrella Top1M domains feed #1013

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

udgover
Copy link
Collaborator

@udgover udgover commented Feb 9, 2024

No description provided.

@udgover udgover linked an issue Feb 9, 2024 that may be closed by this pull request
@udgover udgover requested a review from tomchop February 9, 2024 17:52
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, otherwise LGTM!

plugins/feeds/public/cisco_umbrella_top_domains.py Outdated Show resolved Hide resolved
plugins/feeds/public/cisco_umbrella_top_domains.py Outdated Show resolved Hide resolved
@udgover udgover requested a review from tomchop February 11, 2024 21:23
@tomchop tomchop merged commit 069c000 into main Feb 12, 2024
2 checks passed
@tomchop tomchop deleted the cisco_umbrella_top1m_domains branch February 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top domains feed
2 participants