Change tor_exit_nodes feed to use the Tor Onionoo API + introduce tests #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmvd
commented
Feb 29, 2024
tests/analytics_test.py
Outdated
| @@ -13,48 +13,11 @@ | |||
| from core.schemas.indicator import DiamondModel | |||
| from core.schemas.observable import ObservableType | |||
| from plugins.analytics.public import censys, expire_tags, shodan | |||
| from core.database_arango import ArangoYetiConnector | |||
itsmvd
commented
Feb 29, 2024
tests/feeds.py
Outdated
| defaults["name"] = "FeodoTrackerIPBlocklist" | ||
| feed = feodo_tracker_ip_blocklist.FeodoTrackerIPBlockList(**defaults) | ||
| feed.run() | ||
| # def test_feodo_tracker_ip_blocklist(self): |
There was a problem hiding this comment.
Need to uncomment all these, was for debug purposes
There was a problem hiding this comment.
Whenever you feel ready :)
itsmvd
changed the title
tomchop
requested changes
Mar 3, 2024
tests/feeds.py
Outdated
| defaults["name"] = "FeodoTrackerIPBlocklist" | ||
| feed = feodo_tracker_ip_blocklist.FeodoTrackerIPBlockList(**defaults) | ||
| feed.run() | ||
| # def test_feodo_tracker_ip_blocklist(self): |
There was a problem hiding this comment.
Whenever you feel ready :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move test helper files to a separate module