MISP SSL configuration updates #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to add in the ssl cert verify to be able to connect to a MISP instance over SSL with a self signed cert.
This reverts commit 9635f43.
|
SORRY!!!!!! |
sebdraven
requested changes
Mar 23, 2024
Ran ruff format and got an ok on misp.py
|
I ran ruff, looked fine on misp.py, no errors and said updated. |
|
Perfect thanks for your contribution ! |
sebdraven
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in the misp verify cert option to the sample config.
i'm also going to do a PR for the documentation for showing the
.envvariables for docker.I'm bad at github so i'm sorry for multiple branches/PRs and this replaces #1046 that i accidentally closed while trying to do another one.