Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adds the ability to authenticate with a third-party OIDC provider #925

Merged
merged 14 commits into from
Dec 14, 2023
Merged

Feat: Adds the ability to authenticate with a third-party OIDC provider #925

merged 14 commits into from
Dec 14, 2023

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Dec 1, 2023 •
edited

Companion frontend PR: yeti-platform/yeti-feeds-frontend#85

@tomchop tomchop marked this pull request as ready for review December 2, 2023 11:41
@tomchop tomchop mentioned this pull request Dec 2, 2023
Merged
udgover
udgover reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about error handling. Regarding the implementation itself, it looks good to me but would need to be tested with real login.

core/web/apiv2/auth.py Show resolved Hide resolved
core/web/apiv2/auth.py Outdated Show resolved Hide resolved
core/web/apiv2/auth.py Outdated Show resolved Hide resolved
core/web/apiv2/auth.py Outdated Show resolved Hide resolved
@tomchop
Copy link
Collaborator Author

tomchop commented Dec 9, 2023

The last few commits address the reviewer comments:

  • Better exceptions when OIDC fails
  • Users are still automatically created through OIDC authentication, but they're disabled by default. An (enabled) admin has to come in and enabled them. Added some yetictl utilities to also enable an account through the command line on the server directly

@tomchop tomchop requested a review from udgover December 9, 2023 15:49
udgover
udgover approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomchop tomchop merged commit 699d79d into main Dec 14, 2023
2 checks passed
@tomchop tomchop deleted the oidc branch December 14, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udgover udgover udgover approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchop @udgover