Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Feed bugs #942

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Fix: Feed bugs #942

merged 8 commits into from
Dec 8, 2023

Conversation

sebdraven
Copy link
Collaborator

No description provided.

tomchop
tomchop reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits / questions

plugins/feeds/public/hybrid_analysis.py Outdated Show resolved Hide resolved
plugins/feeds/public/hybrid_analysis.py Outdated Show resolved Hide resolved
tomchop
tomchop approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing. The code seems to do some overly safe checks, but this is due to the crooked nature of the feed.

udgover
udgover approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work to handle all hybrid analysis discrepancies.

@sebdraven sebdraven merged commit 288e3d6 into main Dec 8, 2023
2 checks passed
@sebdraven sebdraven deleted the feed_bugs branch December 8, 2023 06:12
tomgross pushed a commit to tomgross/yeti that referenced this pull request Dec 8, 2023
@sebdraven @tomchop @tomgross
Feed bugs (yeti-platform#942)
0fd4a10 
Co-authored-by: Thomas Chopitea <tomchop@gmail.com>
@tomchop tomchop changed the title Feed bugs Fix: Feed bugs Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udgover udgover udgover approved these changes

@tomchop tomchop tomchop approved these changes

Assignees
No one assigned
Labels
bug tasks:feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebdraven @udgover @tomchop