Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute field model #953

Merged
merged 14 commits into from
Dec 22, 2023
Merged

Compute field model #953

merged 14 commits into from
Dec 22, 2023

Conversation

udgover
Copy link
Collaborator

@udgover udgover commented Dec 16, 2023

No description provided.

tomchop
tomchop requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise LGTM

core/web/apiv2/observables.py Outdated Show resolved Hide resolved
core/schemas/model.py Outdated Show resolved Hide resolved
core/schemas/graph.py Outdated Show resolved Hide resolved
@udgover udgover marked this pull request as ready for review December 22, 2023 13:48
@udgover udgover requested a review from tomchop December 22, 2023 14:03
@tomchop tomchop merged commit 783850b into yeti-platform:main Dec 22, 2023
2 checks passed
@udgover udgover mentioned this pull request Dec 22, 2023
Closed
@tomchop tomchop added the code health Changes about syntax, code health, etc. label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchop tomchop tomchop approved these changes

Assignees
No one assigned
Labels
code health Changes about syntax, code health, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@udgover @tomchop