-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement user account observable #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise LGTM!
https://docs.oasis-open.org/cti/stix/v2.1/os/stix-v2.1-os.html#_azo70vgj1vm2 | ||
|
||
Args: | ||
value: The value of the observable. This is the username of the account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equivalent to which field below? I'm assuming it's repeated in one of the STIX fields? Could we also add a check to ensure that this is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Value should correspond to account_login by default. How should we handle this? Remove account_login attribute and only rely on value? Duplicate value with account_login?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem I see is that values are unique among observables (we should change this to do value / type, like we do for entities). But still, value would probably have to be a concatenation of one or more fields that are more or less expected to be unique...
Otherwise, maybe having a check that both account_login and value are identical would be enough (if we use a property, we'll loose the ability to search by account_login)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated documentation in 36144ea
Then we will need to implement validators for Observables
This PR implements user account observabled based on STIX definition.