Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add netloc to redirect after OIDC auth #958

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Fix: Add netloc to redirect after OIDC auth #958

merged 4 commits into from
Dec 21, 2023

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Dec 19, 2023

No description provided.

@tomchop tomchop added the bug label Dec 19, 2023
@tomchop tomchop requested a review from udgover December 20, 2023 10:06
udgover
udgover requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you were doing tests in real environment and had to setup the relevant redirect uri so it's LGTM, just requesting a small change for a typo in config doc.

yeti.conf.sample Outdated Show resolved Hide resolved
tomchop
tomchop commented Dec 21, 2023
View reviewed changes
yeti.conf.sample Outdated Show resolved Hide resolved
@tomchop tomchop merged commit f95342b into main Dec 21, 2023
2 checks passed
@tomchop tomchop deleted the oidc-redirect branch December 21, 2023 09:50
udgover
udgover reviewed Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udgover udgover udgover requested changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchop @udgover