Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IBAN & BIC observables #985

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Support IBAN & BIC observables #985

merged 1 commit into from
Jan 20, 2024

Conversation

p-l-
Copy link
Contributor

@p-l- p-l- commented Jan 18, 2024

No description provided.

@p-l- p-l- force-pushed the support-bank-ng branch 6 times, most recently from 66e20e6 to 2995694 Compare January 18, 2024 23:45
@p-l- p-l- marked this pull request as ready for review January 18, 2024 23:49
tomchop
tomchop requested changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit regarding uppercase, otherwise LGTM!

core/schemas/observables/iban.py Outdated Show resolved Hide resolved
core/schemas/observables/bic.py Outdated Show resolved Hide resolved
@tomchop
Copy link
Collaborator

tomchop commented Jan 19, 2024

Also worth noting that if you want them to be visible from the UI you'll have to add these to observableDefinitions.json in yeti-feeds-frontend: https://github.com/yeti-platform/yeti-feeds-frontend/blob/main/src/definitions/observableDefinitions.js

@p-l-
Copy link
Contributor Author

p-l- commented Jan 19, 2024 •
edited

Hey @tomchop!

Thanks for your review! I have updated the PR (could not merge your suggestions directly since it had to be changed everywhere).

Also worth noting that if you want them to be visible from the UI you'll have to add these to observableDefinitions.json in yeti-feeds-frontend

That's planned done yes! I just wanted to know if you would accept that change before...

See yeti-platform/yeti-feeds-frontend#138

@p-l- p-l- requested a review from tomchop January 19, 2024 22:49
@p-l- p-l- mentioned this pull request Jan 19, 2024
Merged
@tomchop
Copy link
Collaborator

tomchop commented Jan 20, 2024

Excellent, thanks! Will also have a look at the other one (and merge it)

@tomchop tomchop merged commit 7fc6513 into yeti-platform:main Jan 20, 2024
2 checks passed
@p-l- p-l- deleted the support-bank-ng branch January 20, 2024 19:59
sebdraven added a commit that referenced this pull request Jan 24, 2024
@sebdraven @p-l-
Feat: Support IBAN & BIC observables (#985) (#989)
65852c0 
Co-authored-by: Pierre <pierre@droids-corp.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchop tomchop tomchop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p-l- @tomchop