Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support DFIQ objects #987

Merged
merged 42 commits into from
Feb 2, 2024
Merged

Feat: Support DFIQ objects #987

merged 42 commits into from
Feb 2, 2024

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Jan 22, 2024

This PR adds support for DFIQ objects as specified in https://dfiq.org

Some notes:

  • The source of truth here is the object YAML, any object creation or update comes from a full DFIQ yaml, which is then stored. This makes it easy to preserve the original format and also to "dump" DFIQ objects to their YAML equivalent.
  • Parent / child relationships are enforced through the web API only. It's possible to directly create DFIQ objects in the database without enforcing this
    • e.g., it's possible to directly create a DFIQ object with parent IDs that do not match an object in the database, but not possible through the API)
  • Corresponding frontend PR: Feat: Support DFIQ objects yeti-feeds-frontend#140

Tasks

  • Base scaffolding
  • Tests
  • API from_yaml endpoint
  • API patch updates parent links
  • Tests (API + schema)
  • from_yaml function
  • to_yaml function

@tomchop tomchop requested review from udgover and sebdraven and removed request for udgover January 23, 2024 18:13
@tomchop tomchop marked this pull request as ready for review January 23, 2024 18:14
@tomchop tomchop marked this pull request as draft January 23, 2024 18:14
@tomchop tomchop requested a review from udgover January 24, 2024 22:55
@tomchop tomchop marked this pull request as ready for review January 30, 2024 17:01
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR by directly using the feed and the UI and everything is looking well. I also had a look at the codebase and nothing hurts me. :)

Let's go!

@tomchop tomchop merged commit e2ade76 into main Feb 2, 2024
2 checks passed
@tomchop tomchop deleted the dfiq branch February 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants