Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode errors in commands #766

Closed
devth opened this issue Oct 22, 2018 · 0 comments
Closed

Encode errors in commands #766

devth opened this issue Oct 22, 2018 · 0 comments
Assignees
@devth

Comments

@devth
Copy link
Member

devth commented Oct 22, 2018 •
edited

They should return :result/error so Yetibot knows it's an error.

If a command in a pipeline returns :result/error it short circuits the whole pipeline.
@devth devth added the ready label Oct 22, 2018
@devth devth mentioned this issue Oct 22, 2018
Closed
devth added a commit to yetibot/core that referenced this issue Oct 24, 2018
@devth
Use explicit errors on all collection commands and add error command …
51ca4cb 
…to generate an error

Fix yetibot/yetibot#766
@devth devth mentioned this issue Oct 24, 2018
Merged
@devth devth self-assigned this Oct 24, 2018
@devth devth added in progress and removed ready labels Oct 24, 2018
devth added a commit to yetibot/core that referenced this issue Oct 28, 2018
@devth
Use explicit errors on all collection commands and add error command …
447e9bc 
…to generate an error

Fix yetibot/yetibot#766
devth added a commit to yetibot/core that referenced this issue Oct 30, 2018
@devth
Use explicit errors on all collection commands and add error command … (
b22f67b 
#48)

* Use explicit errors on all collection commands and add error command to generate an error

Fix yetibot/yetibot#766

* Add more explicit error handling

* Add data and error handling on help and history

* Add explicit errors on observers

* Fix bug where data was not propogated when the command appeared to be a collection

* Support data in parse

* Add data on room, ssh, status, that commands

* Add data to uptime and users commands

* Fix uptime resolver

* Avoid sending results of embedded commands if they error out

Fix yetibot/yetibot#767
@devth devth removed the in progress label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devth devth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devth