Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Docker Compose env var Slack example #738

Merged
merged 1 commit into from Oct 3, 2018
Merged

Fixed Docker Compose env var Slack example #738

merged 1 commit into from Oct 3, 2018

Conversation

jcorrado
Copy link
Contributor

@jcorrado jcorrado commented Oct 3, 2018

A tiny change I had to make to get Yetibot, running locally via docker-compose, to connect to my Slack workspace. These vars are correctly specified in doc/DOCKER.md.

Thanks for such a fun project!

@jcorrado
Copy link
Contributor Author

jcorrado commented Oct 3, 2018

@devth please let me know if you'd like an associated issue filed for PRs.

@devth
Copy link
Member

devth commented Oct 3, 2018

@jcorrado thanks! The name should be arbitrary though: you should be able to name it SLACK or MYSLACK or WORK or whatever you want. Did it not work?

@codecov-io
Copy link

Codecov Report

Merging #738 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   41.67%   41.67%           
=======================================
  Files          79       79           
  Lines        2294     2294           
  Branches       84       84           
=======================================
  Hits          956      956           
  Misses       1254     1254           
  Partials       84       84

@devth
Copy link
Member

devth commented Oct 3, 2018

Either way I'll merge to make it consistent with the doc/DOCKER.md doc but I'm curious what the issue was. Also no need to open a separate issue. Thanks for contributing @jcorrado!

@devth devth merged commit 14930e8 into yetibot:master Oct 3, 2018
@jcorrado
Copy link
Contributor Author

jcorrado commented Oct 3, 2018

Hmm, looking back through my console backtrace, I think the issue was the Capitalized Slack for YB_ADAPTERS_*_TYPE. My mistake!

yetibot_1   | 18-10-03 14:51:51 aef4a866ca5d INFO [yetibot.core.adapters.init:33] - Trying Register adapters
yetibot_1   | 18-10-03 14:51:51 aef4a866ca5d WARN [yetibot.core.adapters.init:36] - Error on Register adapters clojure.lang.ExceptionInfo: Unknown adapter type Slack
yetibot_1   |  at clojure.core$ex_info.invokeStatic (core.clj:4739)

@devth
Copy link
Member

devth commented Oct 3, 2018

Got it. No worries!

One thing we're planning to do is make the error messages a lot more friendly by porting all the config verification to clojure.spec. Hopefully that'd help make config errors more obvious.

@jcorrado
Copy link
Contributor Author

jcorrado commented Oct 3, 2018

All in all, this was a super easy setup. Up and running within a few minutes of cloning, without any Yetibot experience! I'm going to try my hand at issue #594 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants