Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avast ye string handlers #747
Avast ye string handlers #747
Changes from all commits
15dab89
8f19669
089d738
bfe18ef
e89a6ad
e24cfe3
8590aeb
811b3aa
0af3169
92160af
d1ce010
7523101
0ab188a
18443b6
569e12d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I think I've hardcoded Pacific Time elsewhere but obtaining from Slack user would be clever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can replace
loop
withreduce
but it's not exactly an improvement.result
(Note I split on whitespace but of course this doesn't retain the user's original whitespace).
I'm fine with it either way; I'm not suggesting you switch to
reduce
as I don't think it's significantly more readable.If I were to continue refactoring I would probably make the
slur-map
vector's length match the length of thewords
vector. It would check if a word is slurrable and put in anil
without affecting overall chance oftrue
values for slurrables.The nice part about making the length match is then we could
map
them together and simplify the slur logic quite a bit: