Karma leaderboard should not including scores of 0 or less #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcorrado
changed the title
|
CI should pass when @devth merges PR yetibot/core#54 and we bump the version dep here. |
|
This tested good, locally, with |
|
|
|
Thanks, @devth! Tested good locally; just pushed bumped version dep. |
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
=======================================
Coverage 44.88% 44.88%
=======================================
Files 84 84
Lines 2522 2522
Branches 87 87
=======================================
Hits 1132 1132
Misses 1303 1303
Partials 87 87 |
devth
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: issue #778