Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dep for yetibot.api.aws #906

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Conversation

jcorrado
Copy link
Contributor

Closes #905

Copy link
Member

@devth devth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jcorrado jcorrado removed the request for review from kaffein March 29, 2019 21:44
@jcorrado
Copy link
Contributor Author

@devth - do you know what's up with that Travis check?
continuous-integration/travis-ci Expected — Waiting for status to be reported

jcorrado added a commit that referenced this pull request Mar 29, 2019
@kaffein
Copy link
Member

kaffein commented Mar 29, 2019

💯 sorry for missing this one guys!!
I had a busy week at work :(

thanks for the fix @jcorrado 👍

@jcorrado
Copy link
Contributor Author

@kaffein, no trouble at all! The test suite ran clean - it was only when using Midje's :autotest, which loads things with greater isolation, that I even noticed. And if you're wondering why I removed you as a reviewer, it had nothing to do with your response time. I was trying to figure out why that one Travis check is (still) stuck 😆 .

@devth
Copy link
Member

devth commented Mar 30, 2019

I think stuck Travis is related to migrating to the new checks based CI. I’ll debug tomorrow!

@devth
Copy link
Member

devth commented Mar 30, 2019

@jcorrado I removed the old Travis integration in favor of the new Checks on travis-ci.com (instead of travis-ci.org), so you're good to merge when ready.

@jcorrado
Copy link
Contributor Author

@devth I don't have permission to merge this, it seems.

@devth
Copy link
Member

devth commented Mar 30, 2019

One second, I was playing with the Settings and must have messed something up this morning.

@devth
Copy link
Member

devth commented Mar 30, 2019

@jcorrado try now?

@jcorrado jcorrado merged commit 8015bd7 into master Mar 30, 2019
@devth devth removed the in progress label Mar 30, 2019
@jcorrado jcorrado deleted the 905-add-missing-aws-dep branch March 30, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants