Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify temps in C or F on weather #910

Merged
merged 4 commits into from Apr 1, 2019

Conversation

jcorrado
Copy link
Contributor

No description provided.

Closes #823

We accept -c or -m for Metric, as [c]elsius is an easy mnemonic; same
thinking with -f or -i for Imperial units.

Started some general cleanup.  Will pull formatters out, next, before
PR.
@jcorrado jcorrado marked this pull request as ready for review March 31, 2019 02:05
@jcorrado jcorrado requested a review from devth March 31, 2019 02:12
@jcorrado
Copy link
Contributor Author

Note: does not yet include PR #907, discussed today.

Copy link
Member

@devth devth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@jcorrado jcorrado merged commit 5b6fa1d into master Apr 1, 2019
@jcorrado jcorrado deleted the 823-weather-choose-units branch April 1, 2019 14:55
@devth devth removed the in progress label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants