Add a cljquotes command for spouting random quotes about Clojure #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justone looks great! If you want to add cache/memoization, there's an example of very simple usage in jira: https://github.com/yetibot/yetibot/blob/master/src/yetibot/api/jira.clj#L392-L394 Up to you if you want to add that. Otherwise we can merge this as is. Thanks! |
|
@devth I added the caching layer. Look ok to merge? |
|
@justone looks good! I’ll merge when I’m back at my keyboard in the next hour. |
devth
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With quotes sourced from https://github.com/Azel4231/clojure-quotes