Improvements to URL's and Tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rev bump
…e new youtube detection regex. - and rev bump
Merging upstream
- updated detection for youtube to detect ok without protocol - updated detection for vimeo to detect ok without protocol - updated vimeo video ID finding regex to handle embed video url format 'player.vimeo.com/video/ID' - updated youtube url to match more of the multiple youtube url formats
- 13456 is an invalid video ID, its too short.
|
Great! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vimeo and youtube urls are now able to handle a few more formats as defined in the tests.
The regex is able to handle a few more formats than the ones covered in the tests, I'm unwilling to add arbitrary test cases till i can find some proper documentation to back up the format. I'm currently looking for a better regex that requires less use of specific match patterns to catch all the various formats. But this one blocks the fake urls you pointed out, and catches all the formats i can think of or have found suggested. I also added more test cases to match the improvements, and fixed a faulty test that didnt use a proper input format to test with.