Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A preview of all the colors in the README.md #34

Merged
merged 1 commit into from
Oct 15, 2016

Conversation

makepanic
Copy link
Contributor

@makepanic makepanic commented Oct 6, 2016

should fix #31

Let's see if github renders it correctly.
I'm not 100% sure if github works fine with the svg hosted on open-colors github.io domain.
See https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown for information.

The layout isn't fixed, if anyone got a better representation idea, I can implement that. The current one is heavily inspired by the current open-color website.

The generated svg looks like this:
20161006-181053

@lukasoppermann
Copy link

Hey @makepanic could you maybe also add the rgb values? It would make it easier to compare if using rgb values.

@makepanic
Copy link
Contributor Author

You mean as rgb(rvalue, gvalue, bvalue)?
Should it display both hex and rgb colors?

@lukasoppermann
Copy link

@makepanic yes. I am not sure about both, but rgb is easier to understand and compare so many people use rgb to compare how closely related colors are. This is much more complicateds with hex values.

@makepanic
Copy link
Contributor Author

@lukasoppermann like this?
20161010-151018

@lukasoppermann
Copy link

@makepanic perfect! Thanks.

@lukasoppermann
Copy link

Actually if this is possible, it would be helpful to generate the same picture with a deuteranopia and protanopia filter as well. Some colors are pretty similar if one has this "impairment" so this would be good to know when designing. Otherwise contrast might be a problem.

@makepanic
Copy link
Contributor Author

I've integrated https://www.npmjs.com/package/color-blind which provides many color blindness transformation methods.
Do you only want deuteranopia and protanopia or all, provided by the library?

Should the complete output be transformed? That is including printed rgb values.

Here's an example output using deuteranopia:

20161010-181034

@lukasoppermann
Copy link

lukasoppermann commented Oct 10, 2016

Hey @makepanic this is pretty nice. Including all might be a nice idea, however I think deuteranopia and protanopia are by far the most common.

Another idea for a visual would be to combine them in every row like this (just a mockup):

example

This would make it easier to see the color you want in all forms, however it might also make it a little confusion, I am not really sure. If so, the deuteranopia and protanopia should probably just be somewhere in a legend, where it explains that the first row isdeuteranopia and the second protanopia. Otherwise it would be quite a bit of repetition.

I think the color codes for the deuteranopia and protanopia colors are not needed, as you are not designing with those colors, but rather with the ones form the package.

@makepanic
Copy link
Contributor Author

I'm not a designer, so maybe we should wait for input from others?
Alternatively, we could split color-blindness generation into a different issue/PR.

That'll allow us to finish the color grid generation first and iterate on it later.

cc: @Larpon @yeun suggestions?

@lukasoppermann
Copy link

@makepanic splitting it up into 2 PRs sounds good to me.

@Larpon
Copy link

Larpon commented Oct 10, 2016

Yup - this is cool stuff. Including it somewhere in the README.md would close #31 IMHO. I don't have any designer glasses either. I was just looking for something to showcase what the project was about :)

@yeun
Copy link
Owner

yeun commented Oct 12, 2016

@makepanic Thanks, nice work! I really love this and also thanks @lukasoppermann for the idea. There's one thing I need to point out; The deuteranopia and protanopia is a bit different with Photoshop preview mode (which I checked). On the Photoshop, deuteranopia and protanopia looks like this:

  • protanopia
    ctr_kbbuaaabfmv
  • deuteranopia
    ctr_kziusaa6el6

I need to check why the both outputs are diffenent. Before then, would you please comment out color-blindness preview emition part in this PR?

@makepanic
Copy link
Contributor Author

@yeun i rebased without the color blindness feature.
I still don't know for sure if github allows the svg linking, so we have to redeploy the website assets to see if it works.

The difference between PS and color-blind could be related to skratchdot/color-blind#1

@sairion
Copy link
Collaborator

sairion commented Oct 15, 2016

@makepanic Seems good!

@sairion sairion merged commit d107098 into yeun:master Oct 15, 2016
@makepanic makepanic deleted the issue/31 branch October 15, 2016 10:07
@makepanic makepanic mentioned this pull request Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A preview of all the colors in the README.md
5 participants