-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A preview of all the colors in the README.md #34
Conversation
Hey @makepanic could you maybe also add the |
You mean as |
@makepanic yes. I am not sure about both, but rgb is easier to understand and compare so many people use rgb to compare how closely related colors are. This is much more complicateds with hex values. |
@lukasoppermann like this? |
@makepanic perfect! Thanks. |
Actually if this is possible, it would be helpful to generate the same picture with a deuteranopia and protanopia filter as well. Some colors are pretty similar if one has this "impairment" so this would be good to know when designing. Otherwise contrast might be a problem. |
I've integrated https://www.npmjs.com/package/color-blind which provides many color blindness transformation methods. Should the complete output be transformed? That is including printed rgb values. Here's an example output using |
Hey @makepanic this is pretty nice. Including all might be a nice idea, however I think Another idea for a visual would be to combine them in every row like this (just a mockup): This would make it easier to see the color you want in all forms, however it might also make it a little confusion, I am not really sure. If so, the I think the color codes for the |
@makepanic splitting it up into 2 PRs sounds good to me. |
Yup - this is cool stuff. Including it somewhere in the README.md would close #31 IMHO. I don't have any designer glasses either. I was just looking for something to showcase what the project was about :) |
@makepanic Thanks, nice work! I really love this and also thanks @lukasoppermann for the idea. There's one thing I need to point out; The I need to check why the both outputs are diffenent. Before then, would you please comment out color-blindness preview emition part in this PR? |
@yeun i rebased without the color blindness feature. The difference between PS and |
@makepanic Seems good! |
should fix #31
Let's see if github renders it correctly.
I'm not 100% sure if github works fine with the svg hosted on open-colors github.io domain.
See https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown for information.
The layout isn't fixed, if anyone got a better representation idea, I can implement that. The current one is heavily inspired by the current open-color website.
The generated svg looks like this: