fixup: new lints from clippy

yewstack · Mar 12, 2024 · 24d815d · 24d815d
1 parent 2e6f17f
commit 24d815d
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/packages/yew/src/callback.rs b/packages/yew/src/callback.rs
@@ -25,7 +25,9 @@ macro_rules! generate_callback_impls {
             }
         }
 
-        #[allow(clippy::vtable_address_comparisons)]
+        // We are okay with comparisons from different compilation units to result in false
+        // not-equal results. This should only lead in the worst-case to some unneeded re-renders.
+        #[allow(ambiguous_wide_pointer_comparisons)]
         impl<IN, OUT> PartialEq for $callback<IN, OUT> {
             fn eq(&self, other: &$callback<IN, OUT>) -> bool {
                 let ($callback { cb }, $callback { cb: rhs_cb }) = (self, other);

diff --git a/packages/yew/src/dom_bundle/utils.rs b/packages/yew/src/dom_bundle/utils.rs
@@ -50,7 +50,6 @@ mod feat_hydration {
 
 #[cfg(feature = "hydration")]
 pub(super) use feat_hydration::*;
-
 #[cfg(test)]
 // this is needed because clippy doesn't like the import not being used
 #[allow(unused_imports)]

diff --git a/packages/yew/src/functional/hooks/use_reducer.rs b/packages/yew/src/functional/hooks/use_reducer.rs
@@ -130,7 +130,10 @@ where
     T: Reducible,
 {
     fn eq(&self, rhs: &Self) -> bool {
-        #[allow(clippy::vtable_address_comparisons)]
+        // We are okay with comparisons from different compilation units to result in false
+        // not-equal results. This should only lead in the worst-case to some unneeded
+        // re-renders.
+        #[allow(ambiguous_wide_pointer_comparisons)]
         Rc::ptr_eq(&self.dispatch, &rhs.dispatch)
     }
 }

diff --git a/packages/yew/src/suspense/suspension.rs b/packages/yew/src/suspense/suspension.rs
@@ -105,7 +105,7 @@ impl Future for Suspension {
 
         let waker = cx.waker().clone();
         self.listen(Callback::from(move |_| {
-            waker.clone().wake();
+            waker.wake_by_ref();
         }));
 
         Poll::Pending

diff --git a/packages/yew/src/virtual_dom/listeners.rs b/packages/yew/src/virtual_dom/listeners.rs
@@ -187,9 +187,11 @@ impl PartialEq for Listeners {
                     lhs.iter()
                         .zip(rhs.iter())
                         .all(|(lhs, rhs)| match (lhs, rhs) {
-                            (Some(lhs), Some(rhs)) =>
-                            {
-                                #[allow(clippy::vtable_address_comparisons)]
+                            (Some(lhs), Some(rhs)) => {
+                                // We are okay with comparisons from different compilation units to
+                                // result in false not-equal results. This should only lead in the
+                                // worst-case to some unneeded re-renders.
+                                #[allow(ambiguous_wide_pointer_comparisons)]
                                 Rc::ptr_eq(lhs, rhs)
                             }
                             (None, None) => true,