Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FetchService to Gloo project #1580

Closed
jstarry opened this issue Sep 22, 2020 · 4 comments
Closed

Migrate FetchService to Gloo project #1580

jstarry opened this issue Sep 22, 2020 · 4 comments

Comments

@jstarry
Copy link
Member

jstarry commented Sep 22, 2020

When rethinking the Fetch service, we should consider implementing for the gloo project. See here for the relevant issue: rustwasm/gloo#4

@jstarry jstarry added this to To do in Pain Point: Fetch Service via automation Sep 22, 2020
@teymour-aldridge
Copy link
Contributor

So I think the key thing is to introduce a mechanism for handling callbacks into gloo. I think what makes sense is to introduce a callback mechanism into gloo which very closely mirrors Yew's and stick some From<yew::Callback> implementations into gloo behind a feature flag.

With that done it should be a fairly easy lift (after adding some things like a builder syntax).

I'm happy to do this.

@hamza1311
Copy link
Member

Why do you think gloo should be based on callbacks for something like fetch? async functions work well and are more idiomatic Rust. Those can be used from Yew like any other future.

@teymour-aldridge
Copy link
Contributor

Oh that's totally true. It's just that the current code we have works with callbacks, but rewriting it to use async does make more sense :D

@hamza1311
Copy link
Member

FetchService is no longer present here so can we close this? The issue in the gloo repo can be used to track this.

@siku2 siku2 closed this as completed Jul 20, 2021
Pain Point: Fetch Service automation moved this from To do to Done Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants