Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define_router_state() Macro is broken for #[cfg(feature="")] types #1615

Closed
jacob-pro opened this issue Oct 11, 2020 · 0 comments · Fixed by #1791
Closed

define_router_state() Macro is broken for #[cfg(feature="")] types #1615

jacob-pro opened this issue Oct 11, 2020 · 0 comments · Fixed by #1791
Labels
A-yew-router Area: The yew-router crate bug
Projects
Router v2

Comments

@jacob-pro
Copy link

Problem
When using define_router_state() with yew_router only Route and RouteService get defined, the cfg feature test does not work because the macro generates code in our own crate rather than the yew_router crate, and is therefore looking at the wrong features.
@jacob-pro jacob-pro added the bug label Oct 11, 2020
@siku2 siku2 added the A-yew-router Area: The yew-router crate label Oct 11, 2020
@siku2 siku2 added this to To do in Router v2 via automation Oct 11, 2020
@hamza1311 hamza1311 mentioned this issue Mar 21, 2021
Merged
3 tasks
Router v2 automation moved this from To do to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-yew-router Area: The yew-router crate bug
Projects
No open projects
Router v2
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite router hamza1311/yew
2 participants
@jacob-pro @siku2