Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate App struct in favor of function based interface #1652

Closed
jstarry opened this issue Nov 24, 2020 · 2 comments
Closed

Deprecate App struct in favor of function based interface #1652

jstarry opened this issue Nov 24, 2020 · 2 comments

Comments

@jstarry
Copy link
Member

jstarry commented Nov 24, 2020

Since we no longer really need the App struct at all, have you thought about deprecating it in favour of a more function-based interface?

// old 
App::<MyComp>::new().mount_with_props(target, props)

// new
yew::mount_with_props::<MyComp>(target, props)

This might even bring the API closer together with yew::start_app and the like.

Originally posted by @siku2 in #1646 (comment)

@jstarry jstarry mentioned this issue Nov 24, 2020
3 tasks
@nicklaswj
Copy link
Contributor

I agree that App currently have no use and it can just as well can be replaced with a function based interface.
HOWEVER: I've made a pull request that actually puts it to use again, and I think the functionality that the PR adds semantically fit in the App struct. #1825

@ranile
Copy link
Member

ranile commented Jun 13, 2021

Didn't #1825 make the required changes? I think this issue should be closed now.

@siku2 siku2 closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants